Swallow promise rejection in registerChild as it is handled via callback #946
+1
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handled via callback
evocateur
changed the title
|
Thanks @viliusl! |
|
No, thank you:) |
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChildProcessUtilities.registerChild()attaches itself to anexecathenable, but then there is no catch, so if command executed fails, there is anunhandledRejection. Givenexecapromise is returned/handled via callback, it's ok to swallow error.Motivation and Context
Not clean - using
lernaapi for an extension and get unhandled rejections in tests:)How Has This Been Tested?
Cleaned-up tests, I could add regression test though.
Types of changes
Checklist: